Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update check #8

Open
MatthewSH opened this issue Jul 24, 2019 · 0 comments
Open

Add update check #8

MatthewSH opened this issue Jul 24, 2019 · 0 comments
Labels
refactor Modification to the existing codebase

Comments

@MatthewSH
Copy link
Contributor

MatthewSH commented Jul 24, 2019

This is a good idea, when you're running the script...there should be some form of hardcoded version in each release. Maybe this would require you making new branches on the release and then making 1 commit on that branch to update version, and release it off that. I've seen this done in Pterodactyl and it works well there.

With that, we can have an update that just quickly gets the latest release from the GitHub API and compares (assuming the version is not canary). This would allow people to know if they're on the latest release or not.

EDIT: Details for Pterodactyl. Recently, when a release is being made...they'll make a branch based off master after everything is merged and the branch will be called release/vX.Y.Z. The release will be based of and tagged at that moment for future storing. Or you can just seperate the branches into a master/develop standard and just use master for releases and worry about all that diff management then.

@adapap adapap added the refactor Modification to the existing codebase label Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Modification to the existing codebase
Projects
None yet
Development

No branches or pull requests

2 participants