Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent popup from rendering empty .notify__section #476

Closed
kirsty-hames opened this issue Nov 30, 2023 · 0 comments · Fixed by #477
Closed

Prevent popup from rendering empty .notify__section #476

kirsty-hames opened this issue Nov 30, 2023 · 0 comments · Fixed by #477
Assignees
@kirsty-hames
Labels
enhancement

Comments

@kirsty-hames
Copy link
Contributor

Subject of the issue

The .notify__section was implemented during a recent PR to expand feedback and add image support. The .notify__section element is rendered regardless if the Notify body or graphic is used. For example, plugins that create their own Notify view such as Hotgraphic.

empty_notify_section

Expected behaviour

Don't render .notify__section unless _graphic.src and/or body exists.

Issue initially raised here for reference cgkineo/adapt-hint#16
@kirsty-hames kirsty-hames moved this from New to Assigned in adapt_framework: The TODO Board Nov 30, 2023
@kirsty-hames kirsty-hames self-assigned this Nov 30, 2023
@kirsty-hames kirsty-hames mentioned this issue Nov 30, 2023
Merged
@kirsty-hames kirsty-hames moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Nov 30, 2023
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
enhancement
Projects
None yet
Milestone
No milestone
1 participant
@kirsty-hames