Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Ignore .nav__skip-btn when hiding nav button labels (fixes #443) #511

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Fix: Ignore .nav__skip-btn when hiding nav button labels (fixes #443) #511

merged 1 commit into from
Mar 27, 2024

Conversation

joe-allen-89
Copy link
Contributor

#443

Fix

@joe-allen-89 joe-allen-89 added the bug Something isn't working label Mar 22, 2024
@joe-allen-89 joe-allen-89 self-assigned this Mar 22, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks - testing on Mac Safari, Chrome and FF.

@oliverfoster oliverfoster merged commit b895d77 into master Mar 27, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/443 branch March 27, 2024 17:26
github-actions bot pushed a commit that referenced this pull request Mar 27, 2024
@semantic-release-bot
Chore(release): 6.46.2
d66704f 
## [6.46.2](v6.46.1...v6.46.2) (2024-03-27)

### Fix

* Ignore .nav__skip-btn when hiding nav button labels (#511) ([b895d77](b895d77)), closes [#511](#511)
@oliverfoster
Copy link
Member

🎉 This PR is included in version 6.46.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip navigation button text is hidden
4 participants
@joe-allen-89 @oliverfoster @kirsty-hames @cahirodoherty-learningpool