Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Include explicitly set ariaLevel (fixes #547) #548

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix: Include explicitly set ariaLevel (fixes #547) #548

merged 1 commit into from
Jun 11, 2024

Conversation

guywillis
Copy link
Contributor

Fixes: #547

Fix

  • Include explicitly set _ariaLevel in relative offset calculation.

@guywillis guywillis added the bug Something isn't working label Jun 5, 2024
@guywillis guywillis self-assigned this Jun 5, 2024
oliverfoster
oliverfoster approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@oliverfoster oliverfoster left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 have seen in action

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 4fea6bd into master Jun 11, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/547 branch June 11, 2024 08:52
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
@semantic-release-bot
Chore(release): 6.51.1
d1d4aae 
## [6.51.1](v6.51.0...v6.51.1) (2024-06-11)

### Fix

* Include explicitly set ariaLevel (#548) ([4fea6bd](4fea6bd)), closes [#548](#548)
@oliverfoster
Copy link
Member

🎉 This PR is included in version 6.51.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@chris-steele chris-steele chris-steele approved these changes

@danielghost danielghost Awaiting requested review from danielghost

Assignees

@guywillis guywillis

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in _ariaLevel calculations
4 participants
@guywillis @oliverfoster @chris-steele @cahirodoherty-learningpool