Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove aria-label from images when alt text is empty (fixes #574) #575

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix: Remove aria-label from images when alt text is empty (fixes #574) #575

merged 1 commit into from
Aug 27, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Aug 20, 2024 •
edited
Loading

Fix #574

Fix

  • Removes the aria-label attribute from images when alt text is empty

Testing

In plugins that use the core image.jsx template (e.g. the Graphic component), set the alt property in the JSON config to an empty string. The aria-label attribute should not be present.

@swashbuck swashbuck self-assigned this Aug 20, 2024
@swashbuck swashbuck added the enhancement New feature or request label Aug 20, 2024
joe-allen-89
joe-allen-89 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit c5d707f into master Aug 27, 2024
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/574 branch August 27, 2024 14:24
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
@semantic-release-bot
Chore(release): 6.53.7
19aa6b3 
## [6.53.7](v6.53.6...v6.53.7) (2024-08-27)

### Fix

* Remove aria-label from images when alt text is empty (fixes #575) ([c5d707f](c5d707f)), closes [#575](#575)
@oliverfoster
Copy link
Member

🎉 This PR is included in version 6.53.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove aria-label from images if alt text is not present
4 participants
@swashbuck @oliverfoster @cahirodoherty-learningpool @joe-allen-89