Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hardcoded icon button border-radius with variable #451

Open
kirsty-hames opened this issue Jul 4, 2023 · 1 comment · May be fixed by #490
Open

Replace hardcoded icon button border-radius with variable #451

kirsty-hames opened this issue Jul 4, 2023 · 1 comment · May be fixed by #490
Assignees
@kirsty-hames
Labels
enhancement

Comments

@kirsty-hames
Copy link
Contributor

kirsty-hames commented Jul 4, 2023 •
edited
Loading

Subject of the enhancement

Notify icon button border-radius is hardcoded at 50%. This should be replaced with a variable as per @item-border-radius and @btn-border-radius.

Ref: issue raised on previous PR #448 (comment)

Update: this also applies to .drawer__btn.
@kirsty-hames kirsty-hames moved this from New to Assigned in adapt_framework: The TODO Board Jul 4, 2023
@kirsty-hames kirsty-hames self-assigned this Jul 4, 2023
@kirsty-hames kirsty-hames mentioned this issue Jul 4, 2023
Merged
@kirsty-hames kirsty-hames removed their assignment Jul 4, 2023
@kirsty-hames kirsty-hames moved this from Assigned to New in adapt_framework: The TODO Board Jul 4, 2023
@kirsty-hames kirsty-hames changed the title Replace hardcoded Notify icon button border-radius with variable Replace hardcoded icon button border-radius with variable Jul 4, 2023
@kirsty-hames kirsty-hames moved this from New to Assigned in adapt_framework: The TODO Board Jan 17, 2024
@kirsty-hames kirsty-hames self-assigned this Jan 17, 2024
@kirsty-hames
Copy link
Contributor Author

kirsty-hames commented Jan 17, 2024 •
edited
Loading

This is being addressed in Adapt buttons #469.

See draft PR. A generic UI variable sets the border-radius for Notify and Drawer views. The default value is 50% as per the current display.

@kirsty-hames kirsty-hames moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Feb 27, 2024
@joe-allen-89 joe-allen-89 moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Mar 25, 2024
@kirsty-hames kirsty-hames moved this from New to Needs Reviewing in adapt_framework: The TODO Board Apr 10, 2024
@joe-allen-89 joe-allen-89 moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Apr 22, 2024
@kirsty-hames kirsty-hames linked a pull request Jul 2, 2024 that will close this issue
Draft
@kirsty-hames kirsty-hames moved this from New to Assigned in adapt_framework: The TODO Board Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
enhancement
Projects
adapt_framework: The TODO Board
Status: Assigned
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Breaking: Adapt buttons overhaul (fixes #469) adaptlearning/adapt-contrib-vanilla
1 participant
@kirsty-hames