Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child views of backbone-forms' modal are not destroyed #2157

Closed
lc-thomasberger opened this issue Dec 13, 2018 · 0 comments
Closed

Child views of backbone-forms' modal are not destroyed #2157

lc-thomasberger opened this issue Dec 13, 2018 · 0 comments
Assignees
@lc-thomasberger
Labels
C: Front-end Issues related to the front-end/UI S: merged Completed, reviewed, and merged issues T: bug
Milestone
0.7.0 Loose ends

Comments

@lc-thomasberger
Copy link
Member

Expected Behaviour

Child Views of backbone-fomrs modal view should be removed when the modal is closed.

Actual Behaviour

Child Views of backbone-fomrs modal view are not properly removed.

Steps to Reproduce

  1. Install Backbone Developer Tools
  2. In the editor with a component that uses modals observe the views that are created
  3. Close the modal. In the list of views, the childviews should not be marked as removed.

Versions

  • Authoring Tool Version: 0.6.0 / develop
  • Framework Version: ---
  • Node.js Version: ---
  • MongoDB Version: ---
  • Operating System: ---
  • Browser: ---
@lc-thomasberger lc-thomasberger added T: bug C: Front-end Issues related to the front-end/UI labels Dec 13, 2018
@lc-thomasberger lc-thomasberger mentioned this issue Dec 13, 2018
Merged
@lc-thomasberger lc-thomasberger added this to the 0.7.0 Loose ends milestone Dec 13, 2018
@lc-thomasberger lc-thomasberger self-assigned this Dec 14, 2018
@lc-thomasberger lc-thomasberger added the S: merged Completed, reviewed, and merged issues label Jan 28, 2019
@taylortom taylortom changed the title backbone-forms modal memory leak Child views of backbone-forms' modal are not destroyed Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lc-thomasberger lc-thomasberger

Labels
C: Front-end Issues related to the front-end/UI S: merged Completed, reviewed, and merged issues T: bug
Projects
None yet
Milestone
0.7.0 Loose ends
Development

No branches or pull requests
2 participants
@lc-thomasberger @canstudios-nicolaw