Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router.js _isCircularNavigationInProgress reset issue #1582

Closed
oliverfoster opened this issue Jun 9, 2017 · 2 comments · Fixed by #1583
Closed

router.js _isCircularNavigationInProgress reset issue #1582

oliverfoster opened this issue Jun 9, 2017 · 2 comments · Fixed by #1583
Assignees
@oliverfoster
Labels
bug

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Jun 9, 2017 •
edited by moloko
Loading

_isCircularNavigationInProgress doesn't reset when canNavigate is set to true.
this is was found by resetting an assessment twice in quick succession (see #1584 and #1585)

note: circular navigation is when a course changes the url when it's not allowed to, the url must be corrected.
@oliverfoster oliverfoster self-assigned this Jun 9, 2017
@oliverfoster oliverfoster mentioned this issue Jun 9, 2017
Merged
@oliverfoster
Copy link
Member Author

i missed a recheck of canNavigate which broke pageIncompletePrompt cgkineo/adapt-pageIncompletePrompt#13

@oliverfoster oliverfoster reopened this Jul 26, 2017
This was referenced Jul 26, 2017
Merged
Closed
@brian-learningpool
Copy link
Member

Code has been merged to master, closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issues/1582: fixed circular routing control reset adaptlearning/adapt_framework
2 participants
@brian-learningpool @oliverfoster