Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageLevelProgress: *-title-inner overrides default when not in use #2523

Closed
chucklorenz opened this issue Sep 23, 2019 · 0 comments · Fixed by adaptlearning/adapt-contrib-vanilla#265

Comments

@chucklorenz
Copy link
Member

pageLevelProgressIndicator.less overrides Adapt default display style even when "_isCompletionIndicatorEnabled": false

.menu-title-inner,
.menu-item-title-inner,
.page-title-inner,
.article-title-inner,
.block-title-inner,
.component-title-inner {
    display: inline-block;
}

I'm running:

  • Framework v4.3.0
  • PLP v4.1.2
  • Chrome 77.0.3865.90
  • Windows 10

Steps to reproduce

  1. Add a component
  2. Configure as "_isCompletionIndicatorEnabled": false
  3. Inspect display style of component-title-inner

Expected behaviour

  • Expecting that the default style display: block is retained when "_isCompletionIndicatorEnabled": false
  • Expecting that the extension style display: inline-block is used only when needed, when "_isCompletionIndicatorEnabled": true

Actual behaviour

The style display: inline-block is applied to all simply by installing the extension.

What impact does this have? On occasion some visual elements need to occupy the same space (e.g., component-title-inner) as the progressbar wants to. Doesn't seem to make sense to have PLP styles interfering when it is not being enabled. Also makes it more difficult to upgrade older courses.

Would prefer a strategy that applies the inline-block style only when the Completion Indicator is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant