Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt-contrib-vanilla - Update media play image to be an icon #2695

Closed
guywillis opened this issue Mar 19, 2020 · 0 comments · Fixed by adaptlearning/adapt-contrib-vanilla#264

Comments

@guywillis
Copy link
Contributor

guywillis commented Mar 19, 2020

Subject of the issue

The media play icon is built using a background image sprite with the hover state created by offsetting the background position. This solution isn't the easiest to maintain or customise.

Current implementation:
screen

Your environment

  • v5 Framework

Proposed solution

Recreate the current implementation but use the newly created video play icon, convert the positioning CSS to use relative values instead of px, and add an opacity transition between default and hover states.

Mock of new implementation:
screen-02

Dependant on #2688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant