-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page header plugin - new component? #2703
Labels
Comments
ghost
self-assigned this
Aug 18, 2020
Linked page header plugin (above) provides the following layouts:
|
Update with menu related bits |
Latest suggestion is to turn menus into pages, such that menus are pages which have other pages as children. Need to investigate. That way the page header would also be useable in the menu. There are some options:
Need to look at:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Subject of the enhancement
The current implementation of the page header concept in Adapt blurs the lines between component and theme. The traditional approach has been to use the theme to style the space at the top of the page using a mix of CSS, JS, and JSON properties. Whilst this has proven to work thus far, I feel that a dedicated plugin would be easier for users new to Adapt to understand as it'll:
Your environment
Proposed solution
Create a new page-header plugin that provides the everything the current Vanilla plugin does (background image, background styles, minimum heights) and formalise support for a text only layout and a background image layout, configurable for both Framework and Authoring Tool users.
The text was updated successfully, but these errors were encountered: