New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt_framework: model json is contaminated with non-json objects #2745

Closed

olivermartinfoster opened this issue May 6, 2020 · 0 comments · Fixed by #2746

Assignees

Labels

bug

Contributor

olivermartinfoster commented May 6, 2020 •

edited

Loading

Subject of the issue

These lines insert non-json data into the models and should be removed:

https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/models/adaptModel.js#L489
https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/models/adaptModel.js#L506
https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/models/itemsComponentModel.js#L30

olivermartinfoster added the bug label

olivermartinfoster added this to the Adapt v6 milestone

olivermartinfoster self-assigned this

olivermartinfoster added the non-breaking label

olivermartinfoster mentioned this issue

issue/2745 decontaminated toJSON functions #2746

Merged

oliverfoster linked a pull request

that will close this issue

issue/2745 decontaminated toJSON functions #2746

Merged

oliverfoster closed this as completed in #2746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment