Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Portuguese month names #99

Closed
danielbichuetti opened this issue Sep 23, 2023 · 4 comments · Fixed by #100
Closed

Feature: Add Portuguese month names #99

danielbichuetti opened this issue Sep 23, 2023 · 4 comments · Fixed by #100
Labels
bug Something isn't working

Comments

@danielbichuetti
Copy link

danielbichuetti commented Sep 23, 2023

Hi @adbar,

Would be possible to add PT month names and abbreviations in the next release?

  • jan janeiro
  • fev fevereiro
  • mar março
  • abr abril
  • mai maio
  • jun junho
  • jul julho
  • ago agosto
  • set setembro
  • out outubro
  • nov novembro
  • dez dezembro

Thanks.

@adbar adbar added the question Further information is requested label Oct 2, 2023
@adbar
Copy link
Owner

adbar commented Oct 2, 2023

Hi @danielbichuetti, for now customized date extraction is not the priority as the heavy lifting should be done by the dateparser library. Is something not working for Portuguese?

@danielbichuetti
Copy link
Author

Hello, @adbar. The date extraction throws a KeyError when it finds "dez" in the text.

@adbar
Copy link
Owner

adbar commented Oct 2, 2023

Thanks for your feedback, I'm going to have a look at this.

@adbar adbar added the bug Something isn't working label Oct 4, 2023
@adbar
Copy link
Owner

adbar commented Oct 4, 2023

Good catch, the fix will be in #100.

@adbar adbar removed the question Further information is requested label Oct 4, 2023
@adbar adbar linked a pull request Oct 4, 2023 that will close this issue
@adbar adbar closed this as completed in #100 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants