Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads: add support to switch between proxies #697

Open
adbar opened this issue Sep 9, 2024 · 0 comments
Open

Downloads: add support to switch between proxies #697

adbar opened this issue Sep 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@adbar
Copy link
Owner

adbar commented Sep 9, 2024

The package now has support for an optional setting where all requests are routed through a proxy. As described in this comment it is not currently possible to switch between proxies or trigger the proxy on demand with each request.

Trafilatura uses two different librairies under the hood: urllib3 (standard) and pycurl (optional). The latter can be easily adapted, however the former uses a connection pool for performance reasons which makes it slightly more difficult to add this new functionality.

Maybe somebody is interested in drafting a PR.
CC @andremacola in case you find some time.

@adbar adbar added the enhancement New feature or request label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant