feat: create dev_daily workflow to sync workflows #42
Conversation
|
Hey @lidavidm, i thought about #30 today and came up with this. The reason I went this route was to work around any auth issues. Creating a true bot would require a PAT or a full-blown GitHub App, or at least I think it would. This works around that by placing the workflow in each repo. Thoughts? I ran a test of the workflow with |
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
This is a great idea!
I think we may also need to fix the templates, e.g. for pixi.toml, some test suites have more dependencies (pytest-lazy-fixtures in particular)
Co-authored-by: David Li <li.davidm96@gmail.com>
Revert "Remove body from PR" This reverts commit 84188b1c0725f32b944c80f69613a610b028d98a. Update dev_daily.yaml
|
Thanks for merging. I was in the middle of debugging a failure I ran into while testing but had to start making dinner. I got this permissions error in https://github.com/amoeba/databricks/actions/runs/20764451655/job/60843093924 that made me think for some reason you can't update workflows from workflows but it worked before during testing so I'm probably just tired. Maybe just keep that in mind when we put it in place. |
|
Oh huh. I think I remember seeing stuff like that before. We just have to add that permission to the list. |
|
You'd think but, unless I'm doing something wrong, you can't add |
|
Ugh. I guess they've changed this around. It seems we have to give the workflow access to a token for this specific purpose. |
|
I'm not sure this really saves us all that much time anymore then...at least, we'd need to be watching for and rotating tokens for each repo which is itself a pain |
|
Or we need to explicitly make a GitHub App which can be granted the permissions |
|
Yeah. I almost submitted a PR to at least avoid the workflow write issue with this commit: amoeba@bcc5e73 but I need to test to confirm this is what I think is going on (tomorrow). |
2 participants
What's Changed
Creates a generated workflow we can add to driver repos which keeps them up to date with any workflow updates in this repo. The workflow runs daily and creates a PR if adbc-gen-workflow generate modified any files.
Ref #30