feat: generate workflow for testing third-party PRs with secrets #43
Conversation
|
Before tackling TODOs and improving this, I'd like to first do #40. |
|
Ok well, I ended up doing #40 as well. |
lidavidm
force-pushed
the
dev
branch
3 times, most recently
from
2b72b2f to
34a11ac
Compare
There was a problem hiding this comment.
A few minor comments but this looks great.
I'm finding myself wanting docs for this and also editor support. Since we're using TOML, we can use tombi's support for JSON schema files. I guess TOML doesn't yet have a schema spec.
I put together a draft of a JSON schema for generate.toml at amoeba@2349bf7 if you're interseted.
| self.permissions: dict[str, bool] = {} | ||
|
|
||
| self.aws = {} | ||
| if aws := raw.pop("aws", {}): |
There was a problem hiding this comment.
I'm not sure I'd understand why this line (92) is written how it is versus how line 99 is.
i.e., why is this not,
self.aws = _require_bool(raw.pop("aws", False), ["aws"])
There was a problem hiding this comment.
aws has subkeys, gcloud doesn't, so aws isn't a bool value
There was a problem hiding this comment.
ah, right. I left this when I was still reviewing. Thanks.
Co-authored-by: Bryce Mecum <petridish@gmail.com>
|
@amoeba if you want to put up a PR for the JSON schema that would be neat. Or maybe Pydantic or something can generate one for us? |
What's Changed
Closes #36.
Closes #40.