Skip to content

Conversation

@lidavidm
Copy link
Contributor

What's Changed

Generalizes the Go workflow for Rust.

@lidavidm lidavidm requested a review from amoeba January 19, 2026 07:58
@lidavidm
Copy link
Contributor Author

Still WIP. @amoeba I did some potentially sketchy stuff with Pydantic.

@amoeba
Copy link
Contributor

amoeba commented Jan 19, 2026

Looks pretty reasonable to me. What did you feel was sketchy with pydantic?

@lidavidm
Copy link
Contributor Author

I had to fight it quite a bit to express the semantics I wanted here, maybe I'm just not used to its vocabulary

Copy link
Contributor

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I pushed up a minor QoL improvement which errors out earlier during the workflow gen process: amoeba@23dbd65.

We could consider caching Rust stuff in CI so speed up builds but it's not critical today I don't think.

@lidavidm lidavidm force-pushed the dev branch 5 times, most recently from 98c036e to 0a59feb Compare January 21, 2026 06:12
@lidavidm lidavidm marked this pull request as ready for review January 21, 2026 06:12
- { platform: linux, arch: amd64, runner: ubuntu-latest }
- { platform: macos, arch: arm64, runner: macos-latest }
- { platform: win, arch: amd64, runner: windows-latest }
- { platform: windows, arch: amd64, runner: windows-latest }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this consistent with below

Comment on lines -219 to -224
- name: Test
if: runner.os != 'Linux'
working-directory: go
run: |
go test -tags assert -v ./...
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some configs may need to be updated to skip tests when not on Linux since now we run the pre-test stuff for all platforms

@lidavidm lidavidm requested a review from amoeba January 21, 2026 06:15
@lidavidm lidavidm merged commit 7fb4170 into main Jan 26, 2026
3 checks passed
@lidavidm lidavidm deleted the dev branch January 26, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants