-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add Rust workflows #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Still WIP. @amoeba I did some potentially sketchy stuff with Pydantic. |
|
Looks pretty reasonable to me. What did you feel was sketchy with pydantic? |
|
I had to fight it quite a bit to express the semantics I wanted here, maybe I'm just not used to its vocabulary |
amoeba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I pushed up a minor QoL improvement which errors out earlier during the workflow gen process: amoeba@23dbd65.
We could consider caching Rust stuff in CI so speed up builds but it's not critical today I don't think.
98c036e to
0a59feb
Compare
| - { platform: linux, arch: amd64, runner: ubuntu-latest } | ||
| - { platform: macos, arch: arm64, runner: macos-latest } | ||
| - { platform: win, arch: amd64, runner: windows-latest } | ||
| - { platform: windows, arch: amd64, runner: windows-latest } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this consistent with below
| - name: Test | ||
| if: runner.os != 'Linux' | ||
| working-directory: go | ||
| run: | | ||
| go test -tags assert -v ./... | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some configs may need to be updated to skip tests when not on Linux since now we run the pre-test stuff for all platforms
What's Changed
Generalizes the Go workflow for Rust.