Fix: Show service account email in UI after creation #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tenant settings page wasn't showing the service account email after creation because the adapter_config_dict passed to the template was missing the service_account_email field. Now the UI will properly show: - Service account email with copy button - Next steps for adding to GAM - Test Connection button Instead of incorrectly showing the 'Create Service Account' button again.
EmmaLouise2018
pushed a commit
that referenced
this pull request
Oct 24, 2025
#517) The tenant settings page wasn't showing the service account email after creation because the adapter_config_dict passed to the template was missing the service_account_email field. Now the UI will properly show: - Service account email with copy button - Next steps for adding to GAM - Test Connection button Instead of incorrectly showing the 'Create Service Account' button again.
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
adcontextprotocol#517) The tenant settings page wasn't showing the service account email after creation because the adapter_config_dict passed to the template was missing the service_account_email field. Now the UI will properly show: - Service account email with copy button - Next steps for adding to GAM - Test Connection button Instead of incorrectly showing the 'Create Service Account' button again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After creating a service account successfully, the UI was not showing the service account details. Instead, it continued to show the "Create Service Account" button.
Root Cause
The adapter_config_dict passed to the template in tenant_settings() was missing the service_account_email field. It only included network_code, refresh_token, trafficker_id, and application_name, but NOT service_account_email.
Solution
Added service_account_email to the adapter_config_dict so the template can correctly detect when a service account exists and display:
Testing
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com