fix: Unskip 3 integration tests and reduce mypy errors by 330 #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is incremental progress on fixing skipped tests and cleaning up type errors. ## Integration Tests Fixed (3 tests) ✅ **test_self_service_signup.py** (13 tests passing) - Fixed OAuth mocking with proper Flask app context - Uses `patch.object(app, "oauth")` instead of complex mocking - Verifies complete signup flow with session management ✅ **test_workflow_lifecycle.py** (7 tests passing) - Added missing `integration_db` fixture dependency - Changed `@pytest.mark.skip_ci` to `@pytest.mark.requires_db` ✅ **test_mcp_tool_roundtrip_minimal.py** (9/13 tests passing) - Fixed to use `mcp_server` fixture instead of manual server - Updated `mcp_server` fixture to use PostgreSQL (fixes architecture violation) - Fixed test fixtures with correct Product schema - Fixed response parsing to use FastMCP's `structured_content` ## mypy Type Errors Fixed (~330 errors, 22% reduction) **Core Schemas (100% clean):** - schemas.py: 43 → 0 errors - Fixed Field() validation constraints (ge/le instead of minimum/maximum) - Fixed Pydantic v2 Field examples parameter - Fixed function parameter type hints **Core Tools (~90 errors fixed):** - creatives.py: 203 → 115 errors (43% reduction) - media_buy_update.py: 118 → 107 errors (9% reduction) - Fixed missing optional fields in constructors - Fixed Literal type annotations **Adapters (100% clean on mock_ad_server):** - mock_ad_server.py: 26 → 0 errors (100% fixed!) - kevel.py: 47 → 23 errors (51% reduction) - triton_digital.py: 52 → 31 errors (40% reduction) **Core Infrastructure:** - main.py: 64 → 16 errors (75% reduction) ## Test Results - Unit tests: 906 passed ✅ - Integration tests: 96 passed ✅ - Integration V2 tests: 120 passed ✅ - E2E tests: 28 passed (3 failed due to port conflicts only) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…extprotocol#627) This is incremental progress on fixing skipped tests and cleaning up type errors. ## Integration Tests Fixed (3 tests) ✅ **test_self_service_signup.py** (13 tests passing) - Fixed OAuth mocking with proper Flask app context - Uses `patch.object(app, "oauth")` instead of complex mocking - Verifies complete signup flow with session management ✅ **test_workflow_lifecycle.py** (7 tests passing) - Added missing `integration_db` fixture dependency - Changed `@pytest.mark.skip_ci` to `@pytest.mark.requires_db` ✅ **test_mcp_tool_roundtrip_minimal.py** (9/13 tests passing) - Fixed to use `mcp_server` fixture instead of manual server - Updated `mcp_server` fixture to use PostgreSQL (fixes architecture violation) - Fixed test fixtures with correct Product schema - Fixed response parsing to use FastMCP's `structured_content` ## mypy Type Errors Fixed (~330 errors, 22% reduction) **Core Schemas (100% clean):** - schemas.py: 43 → 0 errors - Fixed Field() validation constraints (ge/le instead of minimum/maximum) - Fixed Pydantic v2 Field examples parameter - Fixed function parameter type hints **Core Tools (~90 errors fixed):** - creatives.py: 203 → 115 errors (43% reduction) - media_buy_update.py: 118 → 107 errors (9% reduction) - Fixed missing optional fields in constructors - Fixed Literal type annotations **Adapters (100% clean on mock_ad_server):** - mock_ad_server.py: 26 → 0 errors (100% fixed!) - kevel.py: 47 → 23 errors (51% reduction) - triton_digital.py: 52 → 31 errors (40% reduction) **Core Infrastructure:** - main.py: 64 → 16 errors (75% reduction) ## Test Results - Unit tests: 906 passed ✅ - Integration tests: 96 passed ✅ - Integration V2 tests: 120 passed ✅ - E2E tests: 28 passed (3 failed due to port conflicts only) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Incremental progress on fixing skipped tests and cleaning up type errors using parallel subagent approach.
Integration Tests Fixed (3 tests) ✅
test_self_service_signup.py (13 tests passing)
patch.object(app, "oauth")instead of complex mockingtest_workflow_lifecycle.py (7 tests passing)
integration_dbfixture dependency@pytest.mark.skip_cito@pytest.mark.requires_dbtest_mcp_tool_roundtrip_minimal.py (9/13 tests passing)
mcp_serverfixture instead of manual servermcp_serverfixture to use PostgreSQL (was using SQLite, violating PostgreSQL-only architecture)structured_contentmypy Type Errors Fixed (~330 errors, 22% reduction) 🎯
Core Schemas (100% clean ✨)
Core Tools (~90 errors fixed)
Adapters (mock_ad_server 100% clean! ✨)
Core Infrastructure
Test Results 🧪
Approach
Used parallel subagents to tackle both objectives simultaneously:
Next Steps
This PR represents solid incremental progress toward both goals while keeping changes manageable for review.