fix: Update DNS widget to use A record pointing to Approximated proxy IP #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bokelley
force-pushed
the
fix-dns-routing-logic
branch
from
1a7cc47 to
e25381f
Compare
Fixed two issues with the DNS configuration widget: 1. DNS routing architecture - Changed from CNAME to A record - Widget now instructs clients to create A record pointing to 37.16.24.200 - This is the correct Approximated proxy cluster IP address - Previously incorrectly showed CNAME to sales-agent.scope3.com (bypassing proxy) 2. DNS verification error handling - Added error event listener for Approximated DNS widget - Prevents "Unknown sync status: undefined" errors from breaking UI Architecture flow: Client Domain (A → 37.16.24.200) → Approximated Proxy → adcp-sales-agent.fly.dev Changes: - src/admin/blueprints/settings.py: Return proxy_ip instead of dns_target - templates/tenant_settings.html: Use A record type with proxy IP - docker-compose.yml: Add APPROXIMATED_PROXY_IP env var (default: 37.16.24.200) - CLAUDE.md: Update configuration documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
force-pushed
the
fix-dns-routing-logic
branch
from
e25381f to
d37ac20
Compare
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
… IP (adcontextprotocol#636) Fixed two issues with the DNS configuration widget: 1. DNS routing architecture - Changed from CNAME to A record - Widget now instructs clients to create A record pointing to 37.16.24.200 - This is the correct Approximated proxy cluster IP address - Previously incorrectly showed CNAME to sales-agent.scope3.com (bypassing proxy) 2. DNS verification error handling - Added error event listener for Approximated DNS widget - Prevents "Unknown sync status: undefined" errors from breaking UI Architecture flow: Client Domain (A → 37.16.24.200) → Approximated Proxy → adcp-sales-agent.fly.dev Changes: - src/admin/blueprints/settings.py: Return proxy_ip instead of dns_target - templates/tenant_settings.html: Use A record type with proxy IP - docker-compose.yml: Add APPROXIMATED_PROXY_IP env var (default: 37.16.24.200) - CLAUDE.md: Update configuration documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed DNS widget configuration to correctly route through Approximated proxy using an A record instead of CNAME.
Problem
The DNS widget was instructing clients to:
sales-agent.scope3.comSolution
Updated DNS widget to:
37.16.24.200(Approximated proxy cluster IP)Architecture Flow
Changes
src/admin/blueprints/settings.py): Returnproxy_ipinstead ofdns_targettemplates/tenant_settings.html): Use A record type with proxy IPdocker-compose.yml): AddAPPROXIMATED_PROXY_IPenv var (default: 37.16.24.200)CLAUDE.md): Update configuration documentationTesting
Screenshots
See attached images showing:
sales-agent.scope3.com🤖 Generated with Claude Code