fix: Set session role for super admin OAuth login #654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes "Access denied" error for super admin users (e.g., bokelley@scope3.com) logging in via Google OAuth.
Problem
Super admin users successfully authenticated via OAuth but then got "Access denied" when the app tried to redirect them to the admin interface.
Root Cause
The OAuth callback set
session["is_super_admin"] = Truebut didn't setsession["role"] = "super_admin".The index route (
core.py:88) checks for:So super admins would fail this check and hit the access denied path.
Fix
Added
session["role"] = "super_admin"when authenticating super admin users via OAuth, matching the pattern used in the test user login path (auth.py:385):Testing
Related
🤖 Generated with Claude Code