fix: Route external domains to tenant login instead of signup #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When users visited custom domains via Approximated (e.g., sales-agent.accuweather.com), they were incorrectly redirected to the signup landing page instead of the tenant's home page. Root cause: The index() function in core.py always showed landing.html for external domains without checking if a tenant was configured. Solution: Check if tenant exists for external domain. If tenant exists, redirect to login. If no tenant, show signup page. Changes: - src/admin/blueprints/core.py:64-76 - Updated routing logic - tests/unit/test_external_domain_routing.py - Added 5 unit tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
EmmaLouise2018
pushed a commit
that referenced
this pull request
Oct 29, 2025
When users visited custom domains via Approximated (e.g., sales-agent.accuweather.com), they were incorrectly redirected to the signup landing page instead of the tenant's home page. Root cause: The index() function in core.py always showed landing.html for external domains without checking if a tenant was configured. Solution: Check if tenant exists for external domain. If tenant exists, redirect to login. If no tenant, show signup page. Changes: - src/admin/blueprints/core.py:64-76 - Updated routing logic - tests/unit/test_external_domain_routing.py - Added 5 unit tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…extprotocol#661) When users visited custom domains via Approximated (e.g., sales-agent.accuweather.com), they were incorrectly redirected to the signup landing page instead of the tenant's home page. Root cause: The index() function in core.py always showed landing.html for external domains without checking if a tenant was configured. Solution: Check if tenant exists for external domain. If tenant exists, redirect to login. If no tenant, show signup page. Changes: - src/admin/blueprints/core.py:64-76 - Updated routing logic - tests/unit/test_external_domain_routing.py - Added 5 unit tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed routing issue where users visiting custom domains via Approximated were incorrectly redirected to the signup page instead of their tenant's home page.
Example:
http://sales-agent.accuweather.comnow redirects to login instead of signupRoot Cause
The
index()function insrc/admin/blueprints/core.pyalways showed the signup landing page for external domains without checking if a tenant was configured for that virtual host.Solution
Updated routing logic to:
virtual_hostlookup)/loginChanges
src/admin/blueprints/core.py:64-76- Updated external domain routing logictests/unit/test_external_domain_routing.py- Added 5 comprehensive unit testsTesting
All 5 unit tests pass:
Apx-Incoming-HostheaderAll pre-commit hooks passed.
🤖 Generated with Claude Code