fix: Check super admin status before signup flow redirect #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super admins were being redirected to the signup/onboarding flow even when they had valid admin credentials. This fix: 1. Checks super admin status BEFORE checking signup flow 2. Clears any signup flow session state for super admins 3. Ensures super admins always get admin dashboard access Fixes issue where bokelley@scope3.com couldn't access admin UI and was being redirected to signup instead. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…rotocol#674) Super admins were being redirected to the signup/onboarding flow even when they had valid admin credentials. This fix: 1. Checks super admin status BEFORE checking signup flow 2. Clears any signup flow session state for super admins 3. Ensures super admins always get admin dashboard access Fixes issue where bokelley@scope3.com couldn't access admin UI and was being redirected to signup instead. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Super admins (like bokelley@scope3.com) were being redirected to the signup/onboarding flow even when they had valid admin credentials. This was because the signup flow check happened BEFORE the super admin check in the OAuth callback.
Solution
This PR fixes the authentication flow by:
Changes
src/admin/blueprints/auth.pysession.pop('signup_flow')) for super adminsTesting
Production Secrets Updated
Also updated Fly.io production secrets:
SUPER_ADMIN_EMAILS=bokelley@scope3.comSUPER_ADMIN_DOMAINS=scope3.comAction Required
After merging:
sales-agent.scope3.com