fix: Add null safety checks for audience.type and audience.segment_type #682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The targeting browser was throwing a JavaScript error when rendering audiences that don't have a
typeproperty:Console logs showed:
type,segment_type, orstatusfieldsSolution
Added conditional rendering for audience properties that may be undefined:
Changes in
templates/targeting_browser.html:audience.typeexistsaudience.segment_typeexistsaudience.statusbefore comparingBefore:
After:
Impact
Testing
audience.type.replaceRelated to PR #681 which fixed similar field name mismatch in product targeting selector.