fix: display and save custom targeting keys in product inventory #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem:** - Custom targeting key/value pairs weren't being saved to ProductInventoryMapping - Inventory column only showed "None" even when placements/custom keys were assigned **Changes:** 1. Enhanced inventory display: - Changed from total count to breakdown by type (ad_units, placements, custom_keys) - Updated template to show colored badges for each type - Now displays "3 ad units, 1 placement, 2 custom keys" 2. Fixed custom key saving in add_product: - Create ProductInventoryMapping records for custom targeting keys - Store as inventory_type="custom_key" with inventory_id="key=value" 3. Fixed custom key saving in edit_product: - Sync inventory mappings when product is edited - Delete and recreate all mappings from implementation_config - Ensures custom keys are properly tracked **Result:** - Custom targeting keys now persist when saved - Inventory column shows complete breakdown by type - All three inventory types (ad units, placements, custom keys) properly tracked 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…ontextprotocol#692) **Problem:** - Custom targeting key/value pairs weren't being saved to ProductInventoryMapping - Inventory column only showed "None" even when placements/custom keys were assigned **Changes:** 1. Enhanced inventory display: - Changed from total count to breakdown by type (ad_units, placements, custom_keys) - Updated template to show colored badges for each type - Now displays "3 ad units, 1 placement, 2 custom keys" 2. Fixed custom key saving in add_product: - Create ProductInventoryMapping records for custom targeting keys - Store as inventory_type="custom_key" with inventory_id="key=value" 3. Fixed custom key saving in edit_product: - Sync inventory mappings when product is edited - Delete and recreate all mappings from implementation_config - Ensures custom keys are properly tracked **Result:** - Custom targeting keys now persist when saved - Inventory column shows complete breakdown by type - All three inventory types (ad units, placements, custom keys) properly tracked 🤖 Generated with Claude Code Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed two critical issues with product inventory management:
Changes
1. Enhanced Inventory Display
2. Fixed Custom Key Saving in Add Product
3. Fixed Custom Key Saving in Edit Product
Test Coverage
Result
Users can now:
�� Generated with Claude Code