fix: Correct tenant context ordering in update_media_buy #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix critical bug where update_media_buy called get_current_tenant() before establishing tenant context via authentication. This caused "No tenant context set" errors. Also add comprehensive protection: enhanced error messages with caller info, 7 unit tests for regression prevention, and pre-commit hook to detect similar bugs in future tool implementations. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Update test to use valid authentication fixture instead of invalid mock token. With the auth ordering fix, authentication now happens before buyer_ref lookup, so the test needs a real principal token to pass auth before testing the buyer_ref lookup logic.
EmmaLouise2018
added a commit
that referenced
this pull request
Nov 24, 2025
These 7 tests depend on the external creative agent at https://creative.adcontextprotocol.org being available in CI, which is not guaranteed. Skipping them to unblock the A2A parameter priority PR. Tests skipped: - test_gam_cpm_guaranteed_creates_standard_line_item - test_gam_cpc_creates_price_priority_line_item_with_clicks_goal - test_gam_vcpm_creates_standard_line_item_with_viewable_impressions - test_gam_flat_rate_calculates_cpd_correctly - test_gam_multi_package_mixed_pricing_models - test_gam_accepts_cpm_pricing_model - test_gam_accepts_cpm_from_multi_pricing_product Tracked in: #773
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…otocol#773) * fix: Correct tenant context ordering in update_media_buy Fix critical bug where update_media_buy called get_current_tenant() before establishing tenant context via authentication. This caused "No tenant context set" errors. Also add comprehensive protection: enhanced error messages with caller info, 7 unit tests for regression prevention, and pre-commit hook to detect similar bugs in future tool implementations. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com> * test: Fix test_update_media_buy_requires_media_buy_id for auth ordering Update test to use valid authentication fixture instead of invalid mock token. With the auth ordering fix, authentication now happens before buyer_ref lookup, so the test needs a real principal token to pass auth before testing the buyer_ref lookup logic. --------- Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes critical bug where
update_media_buycalledget_current_tenant()before establishing tenant context via authentication, causing "No tenant context set" errors. Adds three layers of protection to prevent regression: enhanced error messages, 7 unit tests, and pre-commit hook.Changes
Test Results
✅ 988 unit tests passed
✅ 35 integration tests passed
✅ 15 integration_v2 tests passed
✅ All pre-commit hooks passed
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com