fix: list_tasks query using non-existent WorkflowStep.tenant_id #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list_tasks MCP tool was failing with AttributeError because WorkflowStep doesn't have a tenant_id column - it links to Context which has tenant_id. Root cause: The query used WorkflowStep.tenant_id which doesn't exist. The # type: ignore[attr-defined] comment suppressed the type error. Fix: Join DBContext and filter on DBContext.tenant_id, matching the pattern used by get_task and complete_task. Why this wasn't caught: - Task tools only register when ADCP_UNIFIED_MODE is set (production) - CI runs without ADCP_UNIFIED_MODE, so tools were never tested - Zero tests existed for list_tasks, get_task, or complete_task Added: - tests/unit/test_task_management_tools.py with 6 behavioral tests - Updated test_tool_registration.py to document unified mode tools Fixes #816 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
force-pushed
the
fix-list-tasks-tenant-id
branch
from
5553a78 to
52137f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
list_tasksMCP tool failing withAttributeError: type object 'WorkflowStep' has no attribute 'tenant_id'Root Cause
The query used
WorkflowStep.tenant_idwhich doesn't exist - WorkflowStep links to Context which has tenant_id. A# type: ignore[attr-defined]comment suppressed the type error.Why Unified Mode Should Be Default
ADCP_UNIFIED_MODE=true(infly.toml)ADCP_UNIFIED_MODE=falseto disable if neededFollow-up Issues Created
# type: ignorecomments (327 across 67 files)Add CI job with ADCP_UNIFIED_MODE=1 to test production config #819- No longer needed since unified mode is now defaultTest plan
Fixes #816
🤖 Generated with Claude Code