Rename media buy status values for clarity #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Rename "pending" to "ready" for media buys that will activate at flight start - Rename "pending_manual" to "pending_approval" for media buys awaiting approval - Update all status logic, templates, and tests to use new terminology The new names better communicate intent: - "ready" = scheduled to go live when flight dates arrive - "pending_approval" = requires manual approval to proceed Updated files: - src/core/schemas.py: MediaBuyDeliveryData status literal - src/core/main.py: Status assignment logic and valid_statuses list - templates/: UI checks for approval status - tests/: Status assertions updated to match new values All AdCP contract tests pass with new status values.
bokelley
added a commit
that referenced
this pull request
Oct 14, 2025
Merged latest changes from main including: - Product pricing display and migration to pricing_options table (#369) - Update media buy fix for database-persisted buys (#380) - Automatic creative preview fetching (#379) - Creative sync improvements (#378, #376, #373) - Budget field access fixes (#374) - UI improvements (#377, #375, #372) Conflict Resolution: - src/core/main.py: Combined debug logging from main with helper function from our branch - Kept both improvements: stderr debug prints + create_get_products_request() helper No conflicts in schema files - automatic merges succeeded.
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
Changes: - Rename "pending" to "ready" for media buys that will activate at flight start - Rename "pending_manual" to "pending_approval" for media buys awaiting approval - Update all status logic, templates, and tests to use new terminology The new names better communicate intent: - "ready" = scheduled to go live when flight dates arrive - "pending_approval" = requires manual approval to proceed Updated files: - src/core/schemas.py: MediaBuyDeliveryData status literal - src/core/main.py: Status assignment logic and valid_statuses list - templates/: UI checks for approval status - tests/: Status assertions updated to match new values All AdCP contract tests pass with new status values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renames media buy status values to more clearly communicate their meaning:
"pending"→"ready"(scheduled to activate at flight start)"pending_manual"→"pending_approval"(requires manual approval)Changes
Status Terminology Updates
"ready" status - For media buys scheduled to start in the future
"pending_approval" status - For media buys requiring manual approval
Files Modified
src/core/schemas.py- UpdatedMediaBuyDeliveryDatastatus literal typesrc/core/main.py- Updated status assignment logic in 3 locations + valid_statuses listtemplates/media_buy_approval.html- Updated approval UI checks (2 locations)templates/workflows.html- Updated workflow status displaytests/unit/test_adcp_contract.py- Updated test with status_filtertests/integration/test_delivery_simulator_restart.py- Updated database querytests/integration/test_workflow_with_server.py- Updated status check logicTesting
✅ All unit tests pass (593 passed)
✅ All integration tests pass (192 passed)
✅ All AdCP contract tests pass (46 passed)
✅ No breaking changes to existing functionality
Impact
Migration Notes
If any external systems check for "pending" status, they should update to check for "ready" status instead.