Fix missing updateApprovalModeUI JavaScript function#377
Merged
Conversation
Fixes ReferenceError when changing creative approval mode dropdown. The function: - Shows/hides mode descriptions (auto-approve, require-human, ai-powered) - Shows/hides AI configuration section when ai-powered mode is selected - Initializes on page load to display correct initial state 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Oct 14, 2025
Merged latest changes from main including: - Product pricing display and migration to pricing_options table (#369) - Update media buy fix for database-persisted buys (#380) - Automatic creative preview fetching (#379) - Creative sync improvements (#378, #376, #373) - Budget field access fixes (#374) - UI improvements (#377, #375, #372) Conflict Resolution: - src/core/main.py: Combined debug logging from main with helper function from our branch - Kept both improvements: stderr debug prints + create_get_products_request() helper No conflicts in schema files - automatic merges succeeded.
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…rebid#377) Fixes ReferenceError when changing creative approval mode dropdown. The function: - Shows/hides mode descriptions (auto-approve, require-human, ai-powered) - Shows/hides AI configuration section when ai-powered mode is selected - Initializes on page load to display correct initial state 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReferenceError: Can't find variable: updateApprovalModeUIwhen changing creative approval mode dropdownChanges
updateApprovalModeUI()function tostatic/js/tenant_settings.jsTest Plan
Before
JavaScript error when changing approval mode dropdown:
After
Dropdown works correctly with proper UI state changes for each mode.
🤖 Generated with Claude Code