Add timeouts to GAM operations to prevent indefinite hangs #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ThreadPoolExecutor-based timeout decorator - Add 10min timeout to discover_placements (AccuWeather hangs here) - Add 5min timeout to discover_labels - Add 10min timeout to discover_custom_targeting - Wrap discovery calls in try/except for partial success - Add 60s timeout to create_order - Add 30s timeout to get_order_status - Add 120s timeout to archive_order and get_order_line_items - Add 300s timeout to create_line_items (batch operations) Fixes AccuWeather syncs hanging indefinitely on placements discovery. Prevents order creation from hanging if GAM API is slow.
- cancel_sync.py: Cancel stuck syncs manually - initialize_tenant_mgmt_api_key.py: Initialize tenant mgmt API key These tools are useful for production operations and troubleshooting.
- check_accuweather_sync.sh: Full sync diagnostic with API checks - quick_sync_check.sh: Quick sync status check with timeout These scripts help diagnose sync issues in production.
This was referenced Oct 24, 2025
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…protocol#587) * Add timeouts to GAM operations to prevent indefinite hangs - Add ThreadPoolExecutor-based timeout decorator - Add 10min timeout to discover_placements (AccuWeather hangs here) - Add 5min timeout to discover_labels - Add 10min timeout to discover_custom_targeting - Wrap discovery calls in try/except for partial success - Add 60s timeout to create_order - Add 30s timeout to get_order_status - Add 120s timeout to archive_order and get_order_line_items - Add 300s timeout to create_line_items (batch operations) Fixes AccuWeather syncs hanging indefinitely on placements discovery. Prevents order creation from hanging if GAM API is slow. * Add operational scripts for sync management - cancel_sync.py: Cancel stuck syncs manually - initialize_tenant_mgmt_api_key.py: Initialize tenant mgmt API key These tools are useful for production operations and troubleshooting. * Add diagnostic scripts for sync troubleshooting - check_accuweather_sync.sh: Full sync diagnostic with API checks - quick_sync_check.sh: Quick sync status check with timeout These scripts help diagnose sync issues in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AccuWeather syncs were hanging indefinitely on placements discovery, and order operations could hang if GAM API was slow.
Solution
Impact
Testing