fix: Clean up smoke tests and resolve warnings #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem:** - Smoke tests had 18 deselected tests (requires_server, skip_ci) - 2 warnings (FastMCP deprecation, SQLAlchemy relationships) - 280+ lines of obsolete SQLite tests - 279 lines of redundant server tests (duplicated integration tests) - Smoke tests took 7s+ and required PostgreSQL in CI **Solution:** 1. Deleted all SQLite migration tests (PostgreSQL-only architecture) 2. Deleted test_smoke_critical_paths.py (redundant with integration tests) 3. Fixed test_config_loader_works to not require database 4. Removed deprecated stateless_http parameter from FastMCP 5. Added overlaps parameter to SQLAlchemy relationships 6. Simplified CI workflow (no DB, no filters) **Results:** - Before: 33 tests (15 selected, 18 deselected), 2 warnings, 1 skipped - After: 14 tests (all run), 0 warnings, 0 skipped - CI: ~2 minutes faster (no PostgreSQL service needed) - Purpose: Fast import/sanity checks before full test suite 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Oct 26, 2025
Merged PRs #628 and #629 from main: - fix: Integration tests, mypy errors, and deprecation warnings (#628) - fix: Clean up smoke tests and resolve warnings (#629) Conflict resolution: - webhook_delivery_service.py: Accepted main's cleaner error handling (single try-except catching ValueError and OSError) Changes from main: - Schema regeneration (extra='forbid' → extra='ignore') - Mypy configuration updates (1081 errors, down from 1586) - Smoke test cleanup (removed test_smoke_critical_paths.py) - Deprecation warning fixes - Integration test improvements
bokelley
added a commit
that referenced
this pull request
Oct 26, 2025
Resolved conflicts in test_signals_agent_workflow.py: - Updated to use origin/main's improved mocking patterns with ExitStack - Removed signals_agent_config from tenant_dict (we removed that field) - Used complete SignalDeployment fields (account, estimated_activation_duration_minutes) - Renamed _add_test_products_v2 to _add_test_products - Added add_required_setup_data call for proper test setup Brings in: - Integration test improvements (#631, #626, #629, #628) - Mypy error reductions - Test infrastructure improvements - 100% integration_v2 test coverage
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
**Problem:** - Smoke tests had 18 deselected tests (requires_server, skip_ci) - 2 warnings (FastMCP deprecation, SQLAlchemy relationships) - 280+ lines of obsolete SQLite tests - 279 lines of redundant server tests (duplicated integration tests) - Smoke tests took 7s+ and required PostgreSQL in CI **Solution:** 1. Deleted all SQLite migration tests (PostgreSQL-only architecture) 2. Deleted test_smoke_critical_paths.py (redundant with integration tests) 3. Fixed test_config_loader_works to not require database 4. Removed deprecated stateless_http parameter from FastMCP 5. Added overlaps parameter to SQLAlchemy relationships 6. Simplified CI workflow (no DB, no filters) **Results:** - Before: 33 tests (15 selected, 18 deselected), 2 warnings, 1 skipped - After: 14 tests (all run), 0 warnings, 0 skipped - CI: ~2 minutes faster (no PostgreSQL service needed) - Purpose: Fast import/sanity checks before full test suite 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
test_config_loader_works→test_config_loader_imports(no DB needed)stateless_httpparameteroverlapsparameter to relationshipsResults
Testing
Smoke tests now serve their actual purpose: fast, simple checks before running the full test suite.