feat: alphabetize targeting keys/values and show display names#687
Merged
feat: alphabetize targeting keys/values and show display names#687
Conversation
Sort targeting keys alphabetically by display name for better UX: - Product page targeting selector dropdown - Targeting browser keys list Uses case-insensitive sorting with localeCompare for proper alphabetical ordering. Applied consistently across both UIs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed three issues with the targeting value selection: 1. **Alphabetize values**: Sort values alphabetically by display_name before populating the dropdown for easier selection 2. **Show display names**: Display human-readable names instead of IDs in the selected targeting badges (e.g., "IAB Content: Travel" instead of "iabctax: IAB20") 3. **Consistent format**: Both key and value now show display names with fallback to internal names if display name not available Implementation: - Sort values using localeCompare after fetching from API - Store display names separately in window.targetingDisplayNames - Lookup display names when rendering selected targeting badges - Handle existing targeting data by building display name mappings Fixes: Selected targeting showing IDs instead of readable names 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…d#687) * feat: alphabetize custom targeting keys in dropdowns and lists Sort targeting keys alphabetically by display name for better UX: - Product page targeting selector dropdown - Targeting browser keys list Uses case-insensitive sorting with localeCompare for proper alphabetical ordering. Applied consistently across both UIs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: alphabetize values and show display names in targeting selector Fixed three issues with the targeting value selection: 1. **Alphabetize values**: Sort values alphabetically by display_name before populating the dropdown for easier selection 2. **Show display names**: Display human-readable names instead of IDs in the selected targeting badges (e.g., "IAB Content: Travel" instead of "iabctax: IAB20") 3. **Consistent format**: Both key and value now show display names with fallback to internal names if display name not available Implementation: - Sort values using localeCompare after fetching from API - Store display names separately in window.targetingDisplayNames - Lookup display names when rendering selected targeting badges - Handle existing targeting data by building display name mappings Fixes: Selected targeting showing IDs instead of readable names 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the targeting selector UX by alphabetizing both keys and values, and displaying human-readable names instead of IDs in the selected targeting badges.
Changes
1. Alphabetize Targeting Keys
Added sorting after fetching keys:
2. Alphabetize Targeting Values
Added sorting after fetching values:
3. Show Display Names in Selected Targeting
Before:
iabctax: IAB20(showed IDs)After:
IAB Content: Travel(shows readable names)Implementation:
window.targetingDisplayNamesBenefits
Before/After
Dropdown Order
Before: Random order from API (Mac Support, Net for Beginners, Palmtops/PDAs, Entertainment, Visual Basic, Web Search, Travel...)
After: Alphabetical order (Entertainment, Mac Support, Net for Beginners, Palmtops/PDAs, Travel, Visual Basic, Web Search...)
Selected Display
Before:
iabctax: IAB20(ID-based)After:
IAB Content: Travel(human-readable)Test plan
🤖 Generated with Claude Code