Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting to a Web Component #49

Closed
jekuer opened this issue Apr 9, 2022 · 0 comments
Closed

Getting to a Web Component #49

jekuer opened this issue Apr 9, 2022 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@jekuer
Copy link
Collaborator

jekuer commented Apr 9, 2022

In order to get closer to a smooth web component, let's work on the following:

  1. move the css into the js file (for better encapsuling when using it the vanilla way without npm). But maybe only for the npm version (therefore, this would be a job for the build process to include the css into the JS). And maybe as a variation, so the developer can decide whether he want to import the whole thing or only the js (adding the css as a second step as it is at the moment).
  2. extend the HTMLElement with an AddToCalendarButton element. As the new default way. Should still be compatible with the div implementation, but have its own semantic one for future implementations.
  3. Offer the option to move the config into data-attributes rather than the JSON way. While the JSON way is still the way to go for Schema.org implementation, data-attributes should be the future default (while still supporting the JSON).
@jekuer jekuer added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 9, 2022
@jekuer jekuer self-assigned this Aug 1, 2022
@jekuer jekuer added this to the V2 milestone Dec 14, 2022
@jekuer jekuer closed this as completed Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant