Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected close test fails #45

Closed
akbennett opened this issue Apr 2, 2018 · 1 comment · Fixed by #50
Closed

Expected close test fails #45

akbennett opened this issue Apr 2, 2018 · 1 comment · Fixed by #50
Labels
Milestone

Comments

@akbennett
Copy link

akbennett commented Apr 2, 2018

self = <tests.test_stock.TestHistorical object at 0x7fda905e40f0>

def test_single_historical_json(self):

    f = get_historical_data("AAPL", self.good_start, self.good_end)
    assert isinstance(f, dict)
    assert len(f["AAPL"]) == 73

    expected1 = f["AAPL"]["2017-02-09"]
  assert expected1["close"] == 132.42

E assert 130.3577 == 132.42

I was making sure I had everything installed properly, but ran into this test failure. As I started to chase down the fail, I get another fail as the historical high seems to be different. I was ok with the close, as it could be adjusted close, but when high was different, I started to question what it 'should' be.

-- My environment:
https://github.com/akbennett/iex-docker

@addisonlynch
Copy link
Owner

@akbennett thanks. Seems as if their data is changing a bit over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants