Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Update got to v10.x #432

Closed
XhmikosR opened this issue Dec 1, 2019 · 4 comments
Closed

[2.x] Update got to v10.x #432

XhmikosR opened this issue Dec 1, 2019 · 4 comments

Comments

@XhmikosR
Copy link
Collaborator

XhmikosR commented Dec 1, 2019

@bezoerb https://github.com/sindresorhus/got/releases/tag/v10.0.0

We will need to drop support for Node.js 8.x but that's OK IMO for v2.x. From a quick test some tests fail.

@bezoerb
Copy link
Collaborator

bezoerb commented Dec 1, 2019

What's the benefit here?

@bezoerb
Copy link
Collaborator

bezoerb commented Apr 8, 2020

Currently got v10 fails with the rejectUnauthorized:false option.
sindresorhus/got#1148
We can update as soon as this is fixed or we have a workaround.

Node.js 8.x support is dropped ;)

@bezoerb
Copy link
Collaborator

bezoerb commented Jun 2, 2020

Seems this RequestError: unable to verify the first certificate issue is caused by the 'old' pupetteer version (1.15.0) used in penthouse.

Running the following script works absolutely fine:

const got = require('got');
(async () => {
  try {
    const response = await got(
      'https://fonts.googleapis.com/css?family=Merriweather:300',
      {
        method: 'head'
      }
    );
    console.log('DONE');
  } catch (error) {
    console.error(error);
  }
})();

But as soon as const puppeteer = require("puppeteer"); is added we get the mentioned error.
It seems like this error is fixed in puppeteer@2.1.0

@bezoerb
Copy link
Collaborator

bezoerb commented Jun 13, 2020

Done with #453

@bezoerb bezoerb closed this as completed Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants