Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test.yml #466

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Update test.yml #466

merged 1 commit into from
Oct 6, 2020

Conversation

XhmikosR
Copy link
Collaborator

@XhmikosR XhmikosR commented Oct 5, 2020 •
edited
Loading

  • Add Node.js 14
  • Add npm caching
  • Switch back to startsWith
  • Switch to Node.js 12.x for coveralls

@XhmikosR XhmikosR requested a review from bezoerb October 5, 2020 18:57
@XhmikosR
Update test.yml
d718b74 
* Add Node.js 14
* Add npm caching
* Switch back to `startsWith`
* Switch to Node.js 12.x for coveralls
@XhmikosR
Copy link
Collaborator Author

XhmikosR commented Oct 5, 2020

The failures seem unrelated @bezoerb ; maybe we need to increase a timeout?

@bezoerb
Copy link
Collaborator

bezoerb commented Oct 6, 2020

fixed this in the deps branch. The site for testing error responses seems to be not available anymore. I hosted my own one and changed the urls

@bezoerb bezoerb merged commit f69c259 into master Oct 6, 2020
@bezoerb bezoerb deleted the XhmikosR-patch-1 branch October 6, 2020 22:21
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bezoerb bezoerb Awaiting requested review from bezoerb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @bezoerb