Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme.md example code not consistent with example.py #4

Open
achimkoh opened this issue Mar 13, 2017 · 3 comments
Open

readme.md example code not consistent with example.py #4

achimkoh opened this issue Mar 13, 2017 · 3 comments
Assignees

Comments

@achimkoh
Copy link

Hi, I noticed that some lines in the example are different from example.py, and seem to call (presumably) deprecated functions.

Regarding from fairml import plot_generic_dependence_dictionary:
There is no plot_generic_dependence_dictionary. Importing plot_dependencies worked for me.

Also,
fig = plot_dependencies( total.get_compress_dictionary_into_key_median(), reverse_values=False, title="FairML feature dependence" ) results in:
AttributeError: 'AuditResult' object has no attribute 'get_compress_dictionary_into_key_median', while total.median() works.

@adebayoj
Copy link
Owner

Hi @achimkoh, you are right. I'll push an update shortly to handle the issues that you mentioned. I'll also update the readme to reflect the changes. Thanks for the issues, please free feel to update us on any other issues you have.

thanks!

@adebayoj adebayoj self-assigned this Mar 13, 2017
@achimkoh
Copy link
Author

Hi thanks for the reply. I had a few minutes and made a pull request so you can have a look!

@JoshuaC3
Copy link

This would be great to have as an IPython notebook. IMO the more examples the better. If I find time I can do one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants