WIP: Improve logging #115
Closed
WIP: Improve logging #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianluediger
requested changes
Mar 28, 2019
There was a problem hiding this comment.
I have tried this in the budgeteer project and it did not seem to work.
The info log message "Report created at xy" is being displayed, but the debug messages are not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #112
Added some additional logging statements to make it easier to see whats going on during testing.
I ran into some issues though: When running the tester's test suite, there is only one log output that says
Saving event to log: ...Here is that I observed:
logger.debug(...)tologger.info(...), the desired output is visible, but we can't use that log level as it is way to verbose for big projectslogback.xmlis found on the classpath during execution, as changing the log level fromdebugtoinfoin that file hides all debug-level outputUPDATE:
Managed to manually configure the log level for the tester. Before we merge these changes however, I'd like to test it out with a few sample projects to see if the logging works as expected with different logging frameworks.
There should also be a reference in the readme.