Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location information requirement for event #86

Closed
ahokkonen opened this issue Mar 20, 2020 · 1 comment
Closed

Location information requirement for event #86

ahokkonen opened this issue Mar 20, 2020 · 1 comment

Comments

@ahokkonen
Copy link
Contributor

ahokkonen commented Mar 20, 2020

@cookeac @erwinspeybroeck @alamers

"location" is not set as required for event resources nor for base core resource (icarEventCoreResource). Is this correct or should location information be always mandatory for events?

Another thing is that in some events required undefined fields:

  • icarMovementArrivalEventResource.json - requirements refers to nonexisting field "originLocation"
  • icarMovementDepartureEventResource.json.json - requirements refers to nonexisting field "destinationLocation"

Both "originLocation" and "destinationLocation" are part of icarConsignmentType and requirement should be declared there I suppose.

@cookeac
Copy link
Collaborator

cookeac commented Mar 23, 2020

As noted, the originLocation and destinationLocation fields were originally in the movement resources and are now in icarConsignmentType and should be removed from the movement resource "required" array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants