refactor(app): output helper instantiation and print trace

adhocore · Aug 21, 2018 · 7b5080e · 7b5080e
1 parent 1783561
commit 7b5080e
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/src/Application.php b/src/Application.php
@@ -271,12 +271,7 @@ public function handle(array $argv)
             $this->doAction($command);
             $exitCode = 0;
         } catch (\Throwable $e) {
-            $this->io()->error($e->getMessage(), true);
-
-            if (!$e instanceof Exception) {
-                $location = \get_class($e) . ' thrown in ' . $e->getFile() . ' on line ' . $e->getLine();
-                $this->io()->bgRed($location, true);
-            }
+            $this->outputHelper()->printTrace($e);
         }
 
         return ($this->onExit)($exitCode);
@@ -311,20 +306,25 @@ protected function aliasesFor(Command $command): array
     public function showHelp()
     {
         $writer = $this->io()->writer();
-        $helper = new OutputHelper($writer);
-
         $header = "{$this->name}, version {$this->version}";
         $footer = 'Run `<command> --help` for specific help';
 
         if ($this->logo) {
             $writer->write($this->logo, true);
         }
 
-        $helper->showCommandsHelp($this->commands(), $header, $footer);
+        $this->outputHelper()->showCommandsHelp($this->commands(), $header, $footer);
 
         return ($this->onExit)();
     }
 
+    protected function outputHelper(): OutputHelper
+    {
+        $writer = $this->io()->writer();
+
+        return new OutputHelper($writer);
+    }
+
     /**
      * Invoke command action.
      *