Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore hotkey on full screen windows is not working for some windows #1130

Closed
usernamelectro opened this issue Feb 12, 2025 · 4 comments
Closed

Comments

@usernamelectro
Copy link

Describe the bug

When I set Settings > Hotkeys > Ignore hotkey on full screen windows to On, it does not work with the full screen YouTube, MPC-HC, and also it will show the search bar over the game that was set as a borderless windowed.
Games with the exclusive full screen are fine though, and also VLC player is okay.

To Reproduce

  1. Open up any video on YouTube.
  2. Press 'f' on a keyboard and put it into the Full screen mode.
  3. Type the hotkey for Fluent Search, in my case it is Ctrl+Space for general search.
  4. Run any game in a borderless windowed mode and try.

Image

Expected behavior

I should not activate search bar when any full screen app is active, but I am not quite sure how would Fluent recognize what is full screen and what isn't.

Question

I suppose it is difficult for Fluent to recognize if the game was set to borderless windowed mode, but can it be done for YouTube, and movie players like MPC-HC?

Environment

  • Microsoft Windows Version 24H2 OS Build 26100.3194
  • Fluent Search Version 1.0.0.85
  • Installation source: Installer
@adirh3
Copy link
Owner

adirh3 commented Feb 14, 2025

I suppose it is difficult for Fluent to recognize if the game was set to borderless windowed mode, but can it be done for YouTube, and movie players like MPC-HC?

That's a good question, I guess it just comes down to the definition of full screen windows.
The short answer is that in some scenarios it may detect borderless full screen windows even if they're not. So, I decided to be on the safe side.

The long answer comes to the two types of windows you think of as full screen.
Full screen popup app - the apps you call Full Screen (e.g. games) are real full screen windows and they're detected by Fluent Search quite easily.

The other scenario is borderless maximized apps (aka windowed full screen) - this is a bit tricky, because it's basically a window that is above taskbar is trying to take as much screen as possible.
There are few issues with it -

  1. Some apps, e.g. YouTube, don't take full screen estate, they are a few pixels short.
  2. The window "styling" that is used to determined whether an app is full screen, maximized, popup, etc. is not consistent across apps.
  3. Having a normal window maximized in screen without a taskbar would be recognized as full screen if I try to detect "borderless" full screen windows.

Due to these issues, I haven't found yet a consistent way to detect full screen; But I will try to improve it next beta builds and update here.

@adirh3
Copy link
Owner

adirh3 commented Feb 14, 2025

This issue has been potentially fixed in version 1.0.0.91. Changelog - https://github.com/adirh3/Fluent-Search/releases/tag/1.0.0.91

@usernamelectro
Copy link
Author

This issue has been potentially fixed in version 1.0.0.91. Changelog - https://github.com/adirh3/Fluent-Search/releases/tag/1.0.0.91

I can confirm that this is fixed, the hotkey is ignored on YouTube, MPC-HC, and on my games that are set to fullscreen borderless windows.

Thanks for a quick fix. That functionality was almost non-existent, but now I will not launch Fluent Search accidentally anymore.

@adirh3
Copy link
Owner

adirh3 commented Feb 14, 2025

@usernamelectro Glad it worked :) If you notice any incorrect behavior, please let me know.

@adirh3 adirh3 closed this as completed Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants