check keyword rules

[stansmith907]

thesaurus is not required in a keyword set. However, when thesaurus appears as an empty hash it does not pass validation. Message is "citation is missing title".

[jlblcc]

Yep, thesaurus is a citation- so a title is required. For keyword{} the thesaurus must either be a valid citation or not present. As noted, an empty object is considered invalid.

[stansmith907]

Yes, title is required for citation, but citation (thesaurus) is not required for keyword. The empty thesaurus object ("thesaurus": {}) is behaving as if a citation is present. I don't remember us making a rule that empty objects are to behave as loaded objects, but maybe we did.

---

I checked other tests and empty objects are ignored. Then I figured out it was because of the way I'm testing. I only test the component in question, I don't run usually run it in from the top and generate a full metadata record. Just testing the module bypasses the schema validation which is early in the stack. And when I do the schema tests they are done on complete objects.

So I guess we did decide (or have to) treat empty objects as complete objects. Kind of sucks.

[jlblcc]

That's just the nature of the schemas. If we have any required properties for an object, an empty object is going to fail validation. In theory, We could write the schemas to allow an empty object, but that would require the oneOf construct for every single object in the schemas.

[stansmith907]

It is what it is.