Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source rule change #174

Closed
2 tasks
stansmith907 opened this issue Dec 16, 2017 · 6 comments
Closed
2 tasks

source rule change #174

stansmith907 opened this issue Dec 16, 2017 · 6 comments
Labels
enhancement Improve or modify an existing feature mdEditor mdEditor update needed
Milestone

Comments

@stansmith907
Copy link
Contributor

New element for source: This is needed to link FGDC's normalized array of data sources with their respective process steps. Similar to ADIwg contactId.

  • "sourceId* {string}: "a unique identifier for the data source"

Rules:

  • sourceId {string} optional
  • description {string} required

mdJson:

{
   "source": [
      {
         "sourceId": "",
         "description": "",
         "sourceCitation": {},
         "metadataCitation": [],
         "spatialResolution": {},
         "referenceSystem": {},
         "sourceProcessStep": [],
         "scope": {}
      }
   ]
}

ISO 19115 mapping:
Does not map to ISO 19115.

FGDC mapping:

<metadata>
  <dataqual>
    <lineage>
      <srcinfo>
        <srccitea>sourceId</srccitea>
      </srcinfo>
    </lineage>
  </dataqual>
</metadata>
@stansmith907 stansmith907 added the enhancement Improve or modify an existing feature label Dec 16, 2017
@jlblcc jlblcc added this to the 2.5.0 milestone Dec 27, 2017
@jlblcc
Copy link
Member

jlblcc commented Apr 18, 2018

Can you confirm that description is required?

@stansmith907
Copy link
Contributor Author

stansmith907 commented Apr 19, 2018

Tricky. The rule is that description is required if scope is not present; and scope is required if description is not present. We have never made much use of scope so I made description required to avoid validation errors. If you want, we can adjust the schema to require one or the other (both are good OK too).

@jlblcc
Copy link
Member

jlblcc commented Apr 19, 2018

🆗 Working on improving lineage support in mdEditor right now, which is why this came up...

@jlblcc
Copy link
Member

jlblcc commented Apr 20, 2018

The rule is that description is required if scope is not present; and scope is required if description is not present.

This is already implemented, see: https://mdtools.adiwg.org/#viewer-page?v=2-2-0-4-0-7-0

@jlblcc
Copy link
Member

jlblcc commented Apr 20, 2018

BTW, I indicate that description is required in the editor.

@stansmith907
Copy link
Contributor Author

stansmith907 commented Apr 20, 2018

That works. Patched now.

@jlblcc jlblcc added the mdEditor mdEditor update needed label Sep 4, 2018
@jlblcc jlblcc closed this as completed in 207743b Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve or modify an existing feature mdEditor mdEditor update needed
Projects
None yet
Development

No branches or pull requests

2 participants