Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new parameters to make available #236

Open
aakash10gupta opened this issue Nov 15, 2024 · 2 comments
Open

new parameters to make available #236

aakash10gupta opened this issue Nov 15, 2024 · 2 comments

Comments

@aakash10gupta
Copy link
Member

Here, I'm listing a few cases where the availability of new parameters will be useful for customizing inversions -

  • preprocessing
    In some cases, the user might need to use their seismograms in their original form without any kind of preprocessing. For instance when the user has already preprocessed their seismograms outside of seisflows. Providing a flag type parameter that can turn on and off ALL preprocessing options will be very helpful in this regard. I'm guessing there will be some consideration needed for the flag to work irrespective of the preprocess module chosen during configuration.

  • windowing
    In some cases, the user might need to use whole lengths of their seismograms for misfit assessments without any window selection, i.e. the whole seismogram is a single window. Providing a flag type parameter that can turn on and off ALL windowing processes will be very helpful in this regard. I'm guessing the windowing is presently undertaken only when preprocess: pyaflowa is chosen during configuration, and hence the proposed flag parameter can only get populated for this preprocess module case.

  • smoothing
    SPECFEM/specfem3d now offers two options for smoothing. For solver: specfem3d, seisflows currently uses the old xsmooth_sem as the default and the only option for smoothing, but it will be good to have a parameter in seisflows which provides an option to choose between that and the new xsmooth_sem_pde option.

@aakash10gupta
Copy link
Member Author

I'm also noticing that the parameter unit_output is missing when preprocess: pyaflowa is used for configuration.

@bch0w
Copy link
Member

bch0w commented Nov 20, 2024

Smoothing was addressed in #230, use parameter smooth_type=='pde' to access PDE smoothing in SPECFEM3D_Cartesian. Preprocessing and windowing will be addressed in future updates.

  • Allow toggling preprocess (anything after data reading) on/off
  • Allow toggling Pyaflowa windowing on/off to use the whole waveform rather than window
  • Bug: Pyaflowa does not use parameter unit_output even though it is an input argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants