Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdjustDelegate is retain #122

Closed
senryxie opened this issue Aug 25, 2015 · 3 comments
Closed

AdjustDelegate is retain #122

senryxie opened this issue Aug 25, 2015 · 3 comments

Comments

@senryxie
Copy link

The code line 91 in ADJConfig.h
@Property (nonatomic, retain) NSObject *delegate;

Although Normally Adjust will be implemented in AppDelegate which will never be released, it's still not a good code practice to use retain with delegate property.

@wellle
Copy link
Member

wellle commented Aug 25, 2015

For reference: ADJConfig.h#L91

@nonelse
Copy link
Member

nonelse commented Aug 25, 2015

Thanks for catching that, we will change it for the next release

@uerceg
Copy link
Contributor

uerceg commented Oct 12, 2015

Fixed in #124.

@uerceg uerceg closed this as completed Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants