Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenUPM Package Contains "Example" Folder - Causing Issues #311

Closed
jtigner-sg opened this issue Sep 6, 2024 · 4 comments
Closed

OpenUPM Package Contains "Example" Folder - Causing Issues #311

jtigner-sg opened this issue Sep 6, 2024 · 4 comments

Comments

@jtigner-sg
Copy link

Package Information

Problem Statement

  • The package contains an Example folder that has a Scene, Prefab, and Script.
  • The folder does not have it's own Assembly definition for Editor-only so it ends up in the default Unity assembly.
  • The scene cannot be opened - image
  • The prefab reports a missing script - image

Suggestion

@JRGreenfield
Copy link

+1 for this idea. This is causing issues for us in the client as well.

@uerceg
Copy link
Contributor

uerceg commented Oct 16, 2024

Hey @jtigner-sg, @JRGreenfield,

Thanks for bringing this up. I wanted to ask do you have any use case for what's inside of the Example folder inside of our package? Asking because we're considering to actually remove it from our Unity package completely. In case there is some benefit in having a script which showcases how Adjust SDK can be used (pretty much the content of the Example folder), we can always extract that into a separate directory in the repo as a reference and still keep it away from the plugin content itself.

Looking forward to hearing back from you.

Cheers.

@uerceg uerceg mentioned this issue Oct 18, 2024
@uerceg
Copy link
Contributor

uerceg commented Oct 18, 2024

At the end, we went with what we had in mind (from the comment above). As of v5.0.4, this should not be the issue anymore. We might consider examples being part of the package in the future in case there's demand for such thing, but we believe that having example scene which uses the SDK in the repo should be enough.

I will be closing this issue, but in case you still have some questions / comments, feel free to comment / reopen.

Cheers

@uerceg uerceg closed this as completed Oct 18, 2024
@JRGreenfield
Copy link

This works for me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants