Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the online LRS Conformance Test support PKI Authentication in addition to username/password? #235

Open
barbara-craig opened this issue Apr 23, 2018 · 3 comments

Comments

@barbara-craig
Copy link

barbara-craig commented Apr 23, 2018

Our LRS is secured by PKI certificate in addition to Basic Authentication. We want to have the online conformance test ran against our LRS. We could remove the Basic Authentication however we cannot remove the Certificate based authentication even for just a test.

Can the LRS Conformance Test support PKI authentication? If so, can we get the public cert that the test will hit our endpoint with? Since we are a DoD site we may be restricted to only allowing DoD certificates. Can this be supported?

Thanks!

@barbara-craig barbara-craig changed the title Can the online LRS Conformance Test support PKI Authentication in addition to username/password? If so, can we get the public cert that the test will hit our endpoint? Can the online LRS Conformance Test support PKI Authentication in addition to username/password? Apr 23, 2018
@vbhayden
Copy link
Member

This is sort of a gray area, as the Spec just requires that one authentication method be used. It leaves room for methods not listed, but the suite does not currently support configuring an arbitrary combination of authentication methods for the tests.

To your point of allowing the suite to authenticate its statements using PKI, I don't see an issue with having that capability. If this is a feature that you will require given the inability to even temporarily remove the PKI auth, then you're welcome to submit a PR for review.

@barbara-craig
Copy link
Author

That would be a great feature. How do you submit a PR for review? Since its now tagged as an enhancement does that mean it has been accepted as a valid request?

Thanks

@vbhayden
Copy link
Member

vbhayden commented May 1, 2018

It's tagged as Enhancement to help sort it against other Issues.

As this project is open-source, anyone can submit a PR (pull request). It usually happens by forking the repository, making the changes, then adding a new pull request on the Github page. Once submitted, team members get a notification that a PR was submitted and review its changes, test, etc.

ADL engineers are going to be under water in terms of workload until late August, so it's unlikely that we will have the time available to implement a feature like this. But, if you or one of your engineers is familiar enough with the project and PKI, then the PR system allows them to contribute to the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants