added user-agent string to requests #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
heeeeyyy, we should implement this instead: https://groups.google.com/forum/#!topic/selenium-developers/Zj1ikTz632o |
|
@jlipps i disagree, we should move forward immediately with the user agent. if they ever get around to adding the cap, then that's great. these are not mutually exclusive paths. |
|
I'm not opposed to them both existing. But if we're using social capital to get something implemented in other projects, I'd prefer getting the more useful long-term approach (structured data in JSON) adopted. |
|
I think we're all in agreement that the useragent + caps is worthwhile. I've summarized the approach & status: appium/appium#4065 |
|
Ok will make it configurable, but enabled by default and add it. |
|
sounds good |
sebv
added a commit
that referenced
this pull request
Apr 21, 2015
added user-agent string to requests
This was referenced Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bootstraponline and I decided to just quickly implement adding user-agent strings to selenium/appium clients for easy identification and bug reporting.
The current format:
author/libraryName/versionIn the future maybe we can add OperatingSystem as well, but we're going for the MVP right now.
see: appium/ruby_lib@af6d44c