Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLOBAL is going away, use global instead #423

Closed
ChALkeR opened this issue Feb 8, 2016 · 1 comment
Closed

GLOBAL is going away, use global instead #423

ChALkeR opened this issue Feb 8, 2016 · 1 comment

Comments

@ChALkeR
Copy link

ChALkeR commented Feb 8, 2016

See nodejs/node#1838.

Your code, as of version 0.4.0:

157374  wd-0.4.0.tgz/test/helpers/skip.js:3:GLOBAL.skip = function () {
157374  wd-0.4.0.tgz/test/helpers/setup.js:99:GLOBAL.should = chai.should();
157374  wd-0.4.0.tgz/test/helpers/setup.js:98:GLOBAL.expect = chai.expect;
157374  wd-0.4.0.tgz/test/helpers/setup.js:97:GLOBAL.AssertionError = chai.AssertionError;
157374  wd-0.4.0.tgz/test/helpers/setup.js:91:GLOBAL.Q = GLOBAL.wd.Q;
157374  wd-0.4.0.tgz/test/helpers/setup.js:84:GLOBAL.prepareJs = function(script) {
157374  wd-0.4.0.tgz/test/helpers/setup.js:7:GLOBAL.uuidLib = require('node-uuid');
157374  wd-0.4.0.tgz/test/helpers/setup.js:76:GLOBAL.sauceJobTitle = function(title) {
157374  wd-0.4.0.tgz/test/helpers/setup.js:63:GLOBAL.mergeDesired = function(desired, extra){
157374  wd-0.4.0.tgz/test/helpers/setup.js:5:GLOBAL.wd = require('../../lib/main');
157374  wd-0.4.0.tgz/test/helpers/setup.js:41:GLOBAL.midwayUrl = function(testSuite, cat, title){
157374  wd-0.4.0.tgz/test/helpers/setup.js:101:GLOBAL.Express = require("./express-helper").Express;
157374  wd-0.4.0.tgz/test/helpers/env.js:4:var env = GLOBAL.env = {};
157374  wd-0.4.0.tgz/test/helpers/env.js:1:GLOBAL._ = require('../../lib/lodash');

There could be other places, better double-check this.

@ChALkeR ChALkeR changed the title GLOBAL is going away. GLOBAL is going away, use global instead Feb 8, 2016
@sebv
Copy link
Collaborator

sebv commented Oct 3, 2016

done

@sebv sebv closed this as completed Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants