Added touch_id method #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrote the method, added API documentations to jsonwire-full-mapping.md, api.md and jsonwire-full.json. Wrote a test in msjon-specs.js.
|
@dang: This has to do with the access PRs have to the encrypted environment variables used to connect through SC. It's a security risk to allow them to be accessed within PRs (since random people would then have them). You can see that all the PRs in this repo fail. :( |
|
Are we able still able to merge this request? |
|
Whoops! Used his Slack handle. @dpgraham I think we ought to be able to. I'm not an owner of this repo, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Wrote the touchId method (see http://stackoverflow.com/questions/25459059/is-there-any-way-to-use-apples-touch-id-fingerprint-scanner-on-ios-simulator for info on touchID simulator)
-Added API documentations to jsonwire-full-mapping.md, api.md and jsonwire-full.json.
-Wrote a test in msjon-specs.js.